Skip to content

GitLab

Switch branch/tag
  1. 13 Aug, 2013 1 commit
  3. 08 Aug, 2013 1 commit
  5. 25 Jul, 2013 1 commit
  7. 15 Mar, 2013 1 commit
  9. 04 Jan, 2013 1 commit
  11. 01 Jan, 2013 1 commit
  13. 20 Oct, 2012 1 commit
  15. 21 Sep, 2012 1 commit
  17. 04 Sep, 2012 2 commits
  19. 27 Aug, 2012 1 commit
  21. 26 Aug, 2012 1 commit
  23. 24 Aug, 2012 1 commit
  25. 28 Jul, 2012 1 commit
  27. 24 Jul, 2012 1 commit
  29. 20 Jul, 2012 1 commit
  31. 27 Apr, 2012 1 commit
  33. 16 Feb, 2012 1 commit
  35. 07 Feb, 2012 1 commit
  37. 09 Nov, 2011 1 commit
  39. 08 Nov, 2011 1 commit
    • Stefan Tauner's avatar
      ichspi: add support for Intel Hardware Sequencing · 50e7c603
      Stefan Tauner authored 
      Based on the new opaque programmer framework this patch adds support
for Intel Hardware Sequencing on ICH8 and its successors.

By default (or when setting the ich_spi_mode option to auto)
the module tries to use swseq and only activates hwseq if need be:
- if important opcodes are inaccessible due to lockdown
- if more than one flash chip is attached.
The other options (swseq, hwseq) select the respective mode (if possible).

A general description of Hardware Sequencing can be found in this blog entry:
http://blogs.coreboot.org/blog/2011/06/11/gsoc-2011-flashrom-part-1/



Besides adding hwseq this patch also introduces these unrelated changes:

- Fix enable_flash_ich_dc_spi to pass ERROR_FATAL from ich_init_spi.
  The whole error handling looks a bit odd to me, so this patch does
  change very little. Also, it does not touch the tunnelcreek method,
  which should be refactored anyway.

- Add null-pointer guards to find_opcode and find_preop
  to matches the other opcode methods better:
  curopcodes == NULL has some meaning and is actively used/checked in
  other functions.

TODO: adding real documentation when we have a directory for it

Corresponding to flashrom svn r1461.
Signed-off-by: default avatarStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
Acked-by: default avatarCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
      50e7c603
  41. 06 Nov, 2011 1 commit
    • Stefan Tauner's avatar
      ichspi: use a variable to distinguish ich generations instead of spi_programmer->type · a8d838d9
      Stefan Tauner authored 
      
The type member is enough most of the time to derive the wanted
information, but
 - not always (e.g. ich_set_bbar),
 - only available after registration, which we want to delay till the
   end of init, and
 - we really want to distinguish between chipset version-grained
   attributes which are not reflected by the registered programmer.

Hence this patch introduces a new static variable which is set up
early by the init functions and allows us to get rid of all "switch
(spi_programmer->type)" in ichspi.c. We reuse the enum introduced
for descriptor mode for the type of the new variable.

Previously magic numbers were passed by chipset_enable wrappers. Now
they use the enumeration items too. To get this working the enum
definition had to be moved to programmer.h.

Another noteworthy detail: previously we have checked for a valid
programmer/ich generation all over the place. I have removed those
checks and added one single check in the init method. Calling any
function of a programmer without executing the init method first, is
undefined behavior.

Corresponding to flashrom svn r1460.
Signed-off-by: default avatarStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
Acked-by: default avatarCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
      a8d838d9
  43. 21 Oct, 2011 1 commit
  45. 09 Sep, 2011 1 commit
  47. 07 Sep, 2011 1 commit
  49. 06 Sep, 2011 1 commit
  51. 03 Sep, 2011 2 commits
  53. 27 Aug, 2011 1 commit
    • Stefan Tauner's avatar
      Fix printing of the Boot BIOS Straps on Intel chipsets · bd0c70ae
      Stefan Tauner authored 
      
The meaning of the bits involved has changed several times in the past.
This patch takes these changes into account and hence fixes the output of the
pretty printing of GCS on all SPI-supported Intel chipsets that are not ICH7 or
NM10 (the latter were unaffected, because the defaults were correct).

This patch also allows to differentiate Ibex Peak and Cougar Point chipsets from
the earlier chipset series (ICH10) by adding new wrapper functions that set
"ich_generation" to 11 and 12 respectively. This should not change behavior
outside of enable_flash_ich_dc_spi, because the code path for
ich_generation >=9 is equal.

alternatively we could just remove the pretty printing of GCS and just output
the bits involved. i would like to keep the pch differentiation anyway though,
because i feel it will become handy in the future.

tested on my QS57-based thinkpad (probe + partial read)

Corresponding to flashrom svn r1423.
Signed-off-by: default avatarStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
Acked-by: default avatarUwe Hermann <uwe@hermann-uwe.de>
      bd0c70ae
  55. 26 Aug, 2011 1 commit
  57. 15 Aug, 2011 1 commit
  59. 07 Aug, 2011 1 commit
  61. 06 Aug, 2011 1 commit
  63. 04 Aug, 2011 1 commit
  65. 28 Jul, 2011 1 commit
  67. 27 Jul, 2011 1 commit
  69. 25 Jul, 2011 2 commits
  71. 21 Jul, 2011 1 commit
    • Stefan Tauner's avatar
      chipset_enable.c: add a message for untested chipset enables · ec8c2484
      Stefan Tauner authored 
      
Old output:
Calibrating delay loop... OK.
Found chipset "Intel QS57", enabling flash write... OK.
This chipset supports the following protocols: FWH, SPI.

new non-verbose output for tested chipsets:
Calibrating delay loop... OK.
Found chipset "Intel QS57". Enabling flash write... OK.
This chipset supports the following protocols: FWH, SPI.

new non-verbose output for untested chipsets:
Found chipset "Intel QS57".
This chipset is marked as untested. If you are using an up-to-date version
of flashrom please email a report to flashrom@flashrom.org including a
verbose (-V) log.
Enabling flash write... OK.
This chipset supports the following protocols: FWH, SPI.

Corresponding to flashrom svn r1379.
Signed-off-by: default avatarStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
Acked-by: default avatarUwe Hermann <uwe@hermann-uwe.de>
      ec8c2484
  73. 13 Jul, 2011 1 commit

Powered by Integricloud