Skip to content

GitLab

Switch branch/tag
  1. 18 Nov, 2008 1 commit
    • Carl-Daniel Hailfinger's avatar
      Check for failed SPI command execution · 598ec58e
      Carl-Daniel Hailfinger authored 
      
Although SPI itself does not have a mechanism to signal command failure,
the SPI host may be unable to send a given command over the wire due
to security or hardware limitations. The current code ignores these
mechanisms completely and simply assumes almost every command succeeds.
Complain if SPI command execution fails.

Since locked down Intel chipsets (like the one we had problems with
earlier) only allow a small subset of commands, find the common subset
of commands between the chipset and the ROM in the chip erase case. That
is accomplished by the new spi_chip_erase_60_c7() which can be used for
chips supporting both 0x60 and 0xc7 chip erase commands.

Both parts of the patch address problems seen in the real world. The
increased verbosity for the error case will help us diagnose and address
problems better.

Corresponding to flashrom svn r345 and coreboot v2 svn r3757.
Signed-off-by: default avatarCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Otherwise: Acked-by: Stefan Reinauer <stepan@coresystems.de>
      598ec58e
  3. 03 Nov, 2008 1 commit
  5. 29 Oct, 2008 1 commit
  7. 18 Oct, 2008 1 commit
  9. 07 Jul, 2008 1 commit
    • Peter Stuge's avatar
      Trivial SPI cleanups · f83221b6
      Peter Stuge authored 
      
While writing a new SPI driver I fixed some things in the SPI code:
All calls to spi_command() had unneccessary #define duplications, and in some
cases the read count define could theoretically become harmful because NULL was
passed for the read buffer. Avoid a crash, should someone change the #defines.

I also noticed that the only caller of spi_page_program() was the it87 driver,
and spi_page_program() could only call back into the it87 driver. Removed the
function for easier-to-follow code and made it8716f_spi_page_program() static.
The ichspi driver's static page functions are already static.

Corresponding to flashrom svn r302 and coreboot v2 svn r3418.
Signed-off-by: default avatarPeter Stuge <peter@stuge.se>
Acked-by: default avatarPeter Stuge <peter@stuge.se>
      f83221b6
  11. 30 Jun, 2008 3 commits
  13. 27 Jun, 2008 1 commit
  15. 24 Jun, 2008 1 commit
    • Peter Stuge's avatar
      Slight restructure of SPI probe_ functions · da4e5f36
      Peter Stuge authored 
      
Preparation for a probe optimization patch. This patch does not change any
functionality. spi_probe_rdid was tested to still work on my M57SLI rev 2.

The idea is to have error checks return error immediately when something
fails, rather than having code inside an if block where the condition
tests for success.

This means: Less indentation, more clear what the code is checking.

Corresponding to flashrom svn r272 and coreboot v2 svn r3386.
Signed-off-by: default avatarPeter Stuge <peter@stuge.se>
Acked-by: default avatarWard Vandewege <ward@gnu.org>
      da4e5f36
  17. 16 May, 2008 1 commit
  19. 15 May, 2008 2 commits
  21. 14 May, 2008 1 commit
  23. 13 May, 2008 3 commits
  25. 10 May, 2008 2 commits
  27. 06 Feb, 2008 1 commit
  29. 22 Jan, 2008 1 commit
  31. 21 Jan, 2008 1 commit
  33. 19 Jan, 2008 1 commit
  35. 04 Jan, 2008 1 commit
  37. 29 Dec, 2007 1 commit
  39. 17 Dec, 2007 1 commit
  41. 16 Dec, 2007 1 commit
  43. 22 Oct, 2007 1 commit
  45. 18 Oct, 2007 2 commits
  47. 17 Oct, 2007 1 commit
  49. 16 Oct, 2007 1 commit
  51. 15 Oct, 2007 1 commit

Powered by Integricloud