Skip to content

GitLab

Switch branch/tag
  1. 07 Sep, 2011 3 commits
  3. 06 Sep, 2011 2 commits
  5. 03 Sep, 2011 3 commits
  7. 31 Aug, 2011 1 commit
  9. 27 Aug, 2011 1 commit
    • Stefan Tauner's avatar
      Fix printing of the Boot BIOS Straps on Intel chipsets · bd0c70ae
      Stefan Tauner authored 
      
The meaning of the bits involved has changed several times in the past.
This patch takes these changes into account and hence fixes the output of the
pretty printing of GCS on all SPI-supported Intel chipsets that are not ICH7 or
NM10 (the latter were unaffected, because the defaults were correct).

This patch also allows to differentiate Ibex Peak and Cougar Point chipsets from
the earlier chipset series (ICH10) by adding new wrapper functions that set
"ich_generation" to 11 and 12 respectively. This should not change behavior
outside of enable_flash_ich_dc_spi, because the code path for
ich_generation >=9 is equal.

alternatively we could just remove the pretty printing of GCS and just output
the bits involved. i would like to keep the pch differentiation anyway though,
because i feel it will become handy in the future.

tested on my QS57-based thinkpad (probe + partial read)

Corresponding to flashrom svn r1423.
Signed-off-by: default avatarStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
Acked-by: default avatarUwe Hermann <uwe@hermann-uwe.de>
      bd0c70ae
  11. 26 Aug, 2011 1 commit
  13. 25 Aug, 2011 3 commits
  15. 20 Aug, 2011 2 commits
  17. 18 Aug, 2011 1 commit
    • Stefan Tauner's avatar
      Makefile: fix and simplify test program compilations · 56787086
      Stefan Tauner authored 
      This was totally broken due to the make's shell function's temporal
behavior.

quote from the gnu make documentation
(http://www.gnu.org/s/hello/manual/make/Shell-Function.html):
"The commands run by calls to the shell function are run when the
function calls are expanded"
we have used the shell function to echo the test programs to a file.
the file name used was equal for all tests and was overwritten for
each test. the result was that all tests (in a single target?) used
the last test program because the echoing of the test programs was
done before all test compilations(!)
see my mail for details:
http://lists.gnu.org/archive/html/bug-make/2011-08/msg00010.html



also the branching for testing ifeq ($(CONFIG_FT2232_SPI), yes) was
unnecessarily complicated.

in my approach here i am using verbatim variables (allows to define
even complex test programs in the makefile without jumping through
hoops) that get exported to environment variables (via "export",
reference afterwards with "$$<varname>").

i have also added the missing redirection of stderr to the compiler
test and changed the definition of ARCH to use simple expansion (:=).

the latter is still wrong, because it uses $(CC) before we check if
a compiler is installed... makes the compiler check pretty much
useless. The simple expansion just reduces the number of errors
printed to 1.

Corresponding to flashrom svn r1416.
Signed-off-by: default avatarStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
Acked-by: default avatarCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
      56787086
  19. 17 Aug, 2011 1 commit
  21. 16 Aug, 2011 1 commit
  23. 15 Aug, 2011 1 commit
  25. 12 Aug, 2011 1 commit
  27. 11 Aug, 2011 2 commits
  29. 09 Aug, 2011 1 commit
  31. 07 Aug, 2011 1 commit
  33. 06 Aug, 2011 3 commits
  35. 04 Aug, 2011 2 commits
  37. 01 Aug, 2011 1 commit
  39. 29 Jul, 2011 3 commits
  41. 28 Jul, 2011 2 commits
  43. 27 Jul, 2011 1 commit
  45. 26 Jul, 2011 3 commits

Powered by Integricloud