1. 27 Apr, 2014 1 commit
  2. 26 Apr, 2014 11 commits
  3. 19 Mar, 2014 2 commits
  4. 17 Mar, 2014 1 commit
  5. 14 Mar, 2014 1 commit
  6. 05 Mar, 2014 1 commit
  7. 21 Nov, 2013 1 commit
  8. 29 Oct, 2013 1 commit
    • Stefan Tauner's avatar
      Ensure DMI strings used in dmi_compare() are not NULL · d1045d8b
      Stefan Tauner authored
      
      Previously the external DMI decoder did not allow this to happen because
      all possible pointers were initialized at startup by the output of
      'dmidecode -s ...' which has default values for all supported types.
      
      The now active internal DMI decoder does work differently: it scans the
      complete DMI table once and copies the available strings. Therefore, strings
      that are not set by the firmware are left at their default value of NULL.
      
      A segfault would arise if the following conditions are all true:
       - the firmware sets up a DMI/SMBIOS table which has at least a correct
         checksum, and
       - that table does *not* define at least one of the DMI strings we use
         for matching (as defined by dmi_strings[] in dmi.c), and
       - there exists a board enable whose PCI IDs are matched by the board,
         and which has a DMI string set that ends with a $ anchor, and
       - the user calls the internal programmer of flashrom without the
         optional mainboard parameter.
      
      This was first observed by Gelip on an abit BF6 using the coreboot port
      for the abit BE6-II V2.0.
      The segfault was reproduced by Idwer Vollering on an ASUS F2A85-M with
      the default DMI values of CONFIG_MAINBOARD_SMBIOS_MANUFACTURER etc.
      overwritten and a forged board enable matching his board.
      Idwer also verified that this patch fixes the problem, thanks a lot!
      
      Corresponding to flashrom svn r1763.
      Signed-off-by: default avatarStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
      Acked-by: default avatarStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
      d1045d8b
  9. 26 Oct, 2013 1 commit
  10. 25 Oct, 2013 1 commit
    • Stefan Tauner's avatar
      Refactor Intel Chipset Enables · 92d6a861
      Stefan Tauner authored
      
       - Combine enable_flash_ich_4e() and enable_flash_ich_dc() to
         enable_flash_ich_fwh().
       - Remove unjustified (chipset) name parameters from various
         enable_flash_ich* functions.
       - Make Poulsbo and Tunnel Creek use generic enables by refining existing
         functions to work with them, including everything in ichspi.c.
       - Refactor enable_flash_ich_fwh_decode() to be called unconditionally for
         all chipsets.
       - Add support for Intel Atom Centerton (S12x0).
       - Recombine ICH2/3/4/5 to CHIPSET_ICH2345 because we treat them equally
         anyway.
       - Move spibar handling out of ich_init_spi() into enable_flash_ich_spi()
       - Various small cleanups.
      
      Corresponding to flashrom svn r1761.
      Signed-off-by: default avatarStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
      Acked-by: default avatarStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
      92d6a861
  11. 21 Oct, 2013 1 commit
  12. 19 Oct, 2013 2 commits
  13. 02 Oct, 2013 5 commits
  14. 23 Sep, 2013 1 commit
  15. 15 Sep, 2013 2 commits
  16. 14 Sep, 2013 4 commits
  17. 13 Sep, 2013 2 commits
  18. 12 Sep, 2013 2 commits