- 18 May, 2014 1 commit
-
-
Stefan Tauner authored
No datasheet available. Tested read, write and all erasers separately by The Raven. He did also provide the patch but refused to sign it off. Corresponding to flashrom svn r1796. Signed-off-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
- 16 May, 2014 4 commits
-
-
Stefan Tauner authored
Allow to set the SPI clock frequency on AMD chipsets with a programmer parameter. If the parameter is given (and matches a possible value), the SPI clock is set temporarily. Both registers are restored on programmer shutdown. Example: ./flashrom -p internal:spispeed="33 MHz" -V Possible values for spispeed are "16.5 MHz", "22 MHz", "33 MHz", "66 MHz", "100 MHZ" and "800 kHz" depending on the chipset generation. Corresponding to flashrom svn r1795. Signed-off-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
Wei Hu authored
This patch adds support for the "SPI 100" SPI engine in Yangtze FCHs (found in Kabini and Temash). Tested reading/writing on ASRock IMB-A180 and PC Engines' APU board. Corresponding to flashrom svn r1794. Signed-off-by:
Wei Hu <wei@aristanetworks.com> Signed-off-by:
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Signed-off-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
Stefan Tauner authored
- Move programmer definition to the top. - Rewrite array accesses to use indices instead of using pointer arithmetic. - Move length check and opcode extraction to a function. - Move IMC parameter handling into existing IMC handling function. - Split comparing and resetting the FIFO pointer. Corresponding to flashrom svn r1793. Signed-off-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
Stefan Tauner authored
This fixes segfaults on reads (implicit reads on writes too), ouch. Thanks to The Raven for reporting the problem and testing my patch, and to Alexander Irenkov for providing a workable fix for it additionally. There were actually two problems: 1) The loop conditions were bogus which could lead to read errors (e.g. on implicit erase verifications). 2) The offset used within the read buffers provided to spi_nbyte_read() and memcpy() were not starting at 0 but the offset of the block within the flash chip (which has nothing to do with read buffer in most cases). This patch works similarly to Alexander's but is intended to be more readable. Corresponding to flashrom svn r1792. Signed-off-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
- 14 May, 2014 1 commit
-
-
Jurij Munda authored
It is very similar to LE25FW418A, except for HD_READ support (that is not implemented in flashrom anyway yet) and allowed voltage range. Probing, erasing, reading and writing has been tested. This chip is found on Seagate Constellation hard drives. Corresponding to flashrom svn r1791. Signed-off-by:
Jurij Munda <jurij.munda@uni-mb.si> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
- 10 May, 2014 1 commit
-
-
Stefan Tauner authored
We are more verbose inside erase_and_write_flash() although it does not matter as much as at the end of the whole process in doit(). New output for the non-fatal (i.e. read-protected + successful recovery read) case: Reading old flash chip contents... done. Erasing and writing flash chip... spi_block_erase_d8 failed during command execution at address 0x8000 Reading current flash chip contents... done. spi_chip_erase_c7 failed during command execution FAILED! Uh oh. Erase/write failed. Checking if anything has changed. Reading current flash chip contents... done. Good, writing to the flash chip apparently didn't do anything. Please check the connections (especially those to write protection pins) between the programmer and the flash chip. If you think the error is caused by flashrom please report this on IRC at chat.freenode.net (channel #flashrom) or mail flashrom@flashrom.org, thanks! Corresponding to flashrom svn r1790. Signed-off-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
- 09 May, 2014 1 commit
-
-
Mark Marshall authored
Corresponding to flashrom svn r1789. Inspired by and mostly based on a patch Signed-off-by:
Mark Marshall <mark.marshall@omicron.at> Signed-off-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
- 07 May, 2014 2 commits
-
-
Stefan Tauner authored
Because the programmer initialization that has to be called way earlier and independently elsewhere, it does not make a lot of sense to deinit within doit(). Also, free the logfile name at the end of main() to catch more execution paths and because this moves it to the other cleanup instructions. Corresponding to flashrom svn r1788. Signed-off-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
Idwer Vollering authored
Tested on hardware by Idwer too. Corresponding to flashrom svn r1787. Signed-off-by:
Idwer Vollering <vidwer@gmail.com> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
- 04 May, 2014 2 commits
-
-
Nikolay Martynov authored
Tested with actual S25FL164K via Arduino SPI. Corresponding to flashrom svn r1786. Signed-off-by:
Nikolay Martynov <mar.kolya@gmail.com> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
Jason Harper authored
Also, refine status register prettyprinting and unlocking of the whole family. Corresponding to flashrom svn r1785. Signed-off-by:
Jason Harper <jharper@iseis.com> Signed-off-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
- 03 May, 2014 2 commits
-
-
Michael Coppola authored
Corresponding to flashrom svn r1784. Signed-off-by:
Michael Coppola <michael.n.coppola@gmail.com> Signed-off-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
Stefan Tauner authored
Tested mainboards: OK: - abit BX6 2.0 Reported by Stefan Tauner - Acer EM61SM/EM61PM (used in Acer Aspire T180) Reported by Benjamin Bellec - ADLINK Express-HR Reported by Obermair Thomas - ASUS M3N-H/HDMI Reported by Franc Serres - Attro G5G100-P Reported by Christoph Grenz - ASRock 960GM-GS3 FX Reported by Fuley Istvan - Elitegroup P6BAP-A+ (V2.2) Reported by Arnaldo Pirrone - Elitegroup GeForce7050M-M (V2.0) Reported by Leif Middelschulte - Fujitsu D3041-A1 (used in ESPRIMO P2560) Reported by Daggi Duck - GIGABYTE GA-8S648 Reported by TeslaBIOS - GIGABYTE GA-970A-D3P (rev. 1.0) Reported by Jean-Francois Pirus - GIGABYTE GA-B85M-D3H Reported by Mladen Milinković - GIGABYTE GA-X79-UD3 Reported by Jeff O'Neil - GIGABYTE GA-X79-UP4 (rev. 1.0) Reported by George Spelvin - GIGABYTE GA-Z68MA-D2H-B3 (rev. 1.3) Reported by Vangelis Skarmoutsos - GIGABYTE GA-Z87-HD3 Reported by virii5 - ...
-
- 02 May, 2014 1 commit
-
-
Stefan Tauner authored
There is no reason for negative delays in our use cases: - We don't need it (to work around any quirks). - sleep() (POSIX) uses an unsigned argument. - usleep() (POSIX) uses an unsigned argument. - Sleep() (Windows) uses an unsigned argument. Change all callees as well (without any complications). Corresponding to flashrom svn r1782. Signed-off-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
- 27 Apr, 2014 1 commit
-
-
Stefan Tauner authored
http://www.tiaowiki.com/w/TIAO_USB_Multi_Protocol_Adapter_Lite_User's_Manual Initial patch from Jadran Puharic <jpuharic@gmail.com>. Corresponding to flashrom svn r1781. Signed-off-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
- 26 Apr, 2014 11 commits
-
-
Stefan Tauner authored
Corresponding to flashrom svn r1780. Signed-off-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
Stefan Reinauer authored
Also, try to always disable WRDI because else the user is stuck with a chip in AAI mode that won't return by itself w/o a reset. Corresponding to flashrom svn r1779. Signed-off-by:
Stefan Reinauer <stefan.reinauer@coreboot.org> Signed-off-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
Stefan Reinauer authored
The one in the error case of register_shutdown() was discovered while reviewing the other one found by Coverity and fixed by Stefan Reinauer. Corresponding to flashrom svn r1778. Signed-off-by:
Stefan Reinauer <stefan.reinauer@coreboot.org> Signed-off-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
Stefan Reinauer authored
Corresponding to flashrom svn r1777. Signed-off-by:
Stefan Reinauer <stefan.reinauer@coreboot.org> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
Stefan Reinauer authored
What we really want to do is check whether PCI_BASE_ADDRESS_2 is valid at this point, and not PCI_BASE_ADDRESS_0. Corresponding to flashrom svn r1776. Signed-off-by:
Stefan Reinauer <stefan.reinauer@coreboot.org> Signed-off-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
Stefan Reinauer authored
Corresponding to flashrom svn r1775. Signed-off-by:
Stefan Reinauer <stefan.reinauer@coreboot.org> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
Stefan Reinauer authored
Memory leak in ogp_spi_init(). Corresponding to flashrom svn r1774. Signed-off-by:
Stefan Reinauer <stefan.reinauer@coreboot.org> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
Stefan Reinauer authored
Corresponding to flashrom svn r1773. Signed-off-by:
Stefan Reinauer <stefan.reinauer@coreboot.org> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
Stefan Reinauer authored
Corresponding to flashrom svn r1772. Signed-off-by:
Stefan Reinauer <stefan.reinauer@coreboot.org> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
Stefan Reinauer authored
Corresponding to flashrom svn r1771. Signed-off-by:
Stefan Reinauer <stefan.reinauer@coreboot.org> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
Stefan Reinauer authored
Corresponding to flashrom svn r1770. Signed-off-by:
Stefan Reinauer <stefan.reinauer@coreboot.org> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
- 19 Mar, 2014 2 commits
-
-
Alexandru Gagniuc authored
'speed' is stored in Hz, so rename the variable to 'speed_hz' to clarify any potential confusion. Also, when printing the speed after setting it with an ioctl, convert it to kHz to match the units given in the message. Corresponding to flashrom svn r1769. Signed-off-by:
Alexandru Gagniuc <mr.nuke.me@gmail.com> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
Alexandru Gagniuc authored
A kilohertz is exactly 1000 hertz, not 1024 hertz. Corresponding to flashrom svn r1768. Signed-off-by:
Alexandru Gagniuc <mr.nuke.me@gmail.com> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
- 17 Mar, 2014 1 commit
-
-
Bill Paul authored
Corresponding to flashrom svn r1767. Signed-off-by:
Bill Paul <wpaul@windriver.com> Acked-by:
Idwer Vollering <vidwer@gmail.com>
-
- 14 Mar, 2014 1 commit
-
-
François Revol authored
Use the same trick as for the MX-SE variant. Despite being mentioned as supported on http://flashrom.org/Supported_hardware flashrom fails to detect the flash chip without this. Corresponding to flashrom svn r1766. Signed-off-by:
François Revol <revol@free.fr> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
- 05 Mar, 2014 1 commit
-
-
Carl-Daniel Hailfinger authored
Convert all physmaps in dmi.c to use aligned readonly maps. Convert all physmaps in cbtable.c to use unaligned readonly maps. Make physunmap() a generic architecture-independent wrapper. Add physunmap_unaligned() to complement physmap*_unaligned(). Corresponding to flashrom svn r1765. Signed-off-by:
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
- 21 Nov, 2013 1 commit
-
-
Stefan Tauner authored
Tested on real hardware by TeslaBIOS. Besides the usual board_enable stuff the GPIO definitions for the ICH7 DH were also missing. Apparently Intel forgot to add the PCI IDs for the desktop version in the spec update, but the normal datasheet mentions the DH desktop version so this should be fine... Corresponding to flashrom svn r1764. Signed-off-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
- 29 Oct, 2013 1 commit
-
-
Stefan Tauner authored
Previously the external DMI decoder did not allow this to happen because all possible pointers were initialized at startup by the output of 'dmidecode -s ...' which has default values for all supported types. The now active internal DMI decoder does work differently: it scans the complete DMI table once and copies the available strings. Therefore, strings that are not set by the firmware are left at their default value of NULL. A segfault would arise if the following conditions are all true: - the firmware sets up a DMI/SMBIOS table which has at least a correct checksum, and - that table does *not* define at least one of the DMI strings we use for matching (as defined by dmi_strings[] in dmi.c), and - there exists a board enable whose PCI IDs are matched by the board, and which has a DMI string set that ends with a $ anchor, and - the user calls the internal programmer of flashrom without the optional mainboard parameter. This was first observed by Gelip on an abit BF6 using the coreboot port for the abit BE6-II V2.0. The segfault was reproduced by Idwer Vollering on an ASUS F2A85-M with the default DMI values of CONFIG_MAINBOARD_SMBIOS_MANUFACTURER etc. overwritten and a forged board enable matching his board. Idwer also verified that this patch fixes the problem, thanks a lot! Corresponding to flashrom svn r1763. Signed-off-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
- 26 Oct, 2013 1 commit
-
-
Stefan Tauner authored
Because the board does not have any PCI subsystem IDs set and the DMI strings are not very specific at all, autodetection has been disabled. The GPIO was found by roxfan and the patch tested on hardware by Gelip, thanks! Corresponding to flashrom svn r1762. Signed-off-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
- 25 Oct, 2013 1 commit
-
-
Stefan Tauner authored
- Combine enable_flash_ich_4e() and enable_flash_ich_dc() to enable_flash_ich_fwh(). - Remove unjustified (chipset) name parameters from various enable_flash_ich* functions. - Make Poulsbo and Tunnel Creek use generic enables by refining existing functions to work with them, including everything in ichspi.c. - Refactor enable_flash_ich_fwh_decode() to be called unconditionally for all chipsets. - Add support for Intel Atom Centerton (S12x0). - Recombine ICH2/3/4/5 to CHIPSET_ICH2345 because we treat them equally anyway. - Move spibar handling out of ich_init_spi() into enable_flash_ich_spi() - Various small cleanups. Corresponding to flashrom svn r1761. Signed-off-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
- 21 Oct, 2013 1 commit
-
-
Urja Rannikko authored
We use 0 as delay value for some chips. Just skipping these here is the most elegant, maintainable solution. Corresponding to flashrom svn r1760. Signed-off-by:
Urja Rannikko <urjaman@gmail.com> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
- 19 Oct, 2013 2 commits
-
-
Urja Rannikko authored
Using programmer_delay() for timeouts in serial writes could cause a (theoretically) endless recursion if serial communication is used to send the programmer the delay command to be executed on the programmer instead of the host which fails again, following a timeout which sends... Corresponding to flashrom svn r1759. Signed-off-by:
Urja Rannikko <urjaman@gmail.com> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
Cory Henderson authored
- Reorder some models and refine comments. - Add SST25VF512A: AAI is available but with an uncommon opcode (0xAF). Fully tested with Bus Pirate 3.5 running 6.2 beta firmware by Cory. - Add SST25VF020 and SST25VF020B. Corresponding to flashrom svn r1758. Signed-off-by:
Cory Henderson <dcoryh192@gmail.com> Signed-off-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-
- 02 Oct, 2013 1 commit
-
-
Kyösti Mälkki authored
Pin 6 on LPT controls a pulldown on MISO/TDO signal. Whether there exists an unbuffered clone is unknown. The author of the original patch confirmed in private correspondence that the patch was incomplete. There has been no sign of an unbuffered version on the interwebs, hence just change the existing driver to disable the pulldown. Corresponding to flashrom svn r1757. Signed-off-by:
Kyösti Mälkki <kyosti.malkki@gmail.com> Signed-off-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by:
Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-