• Andrew Jeffery's avatar
    protocol: Rework publication of events over DBus transport · fd4fa34d
    Andrew Jeffery authored
    A set of races was discovered around the propagation of HIOMAP protocol
    BMC status events during BMC shutdown. In particular the change impacts
    the design of the DBus transport defined in the protocol specification,
    as signalling of both acknowledgeable and non-acknowledgeable events
    could not be made atomic.
    A particular case where this matters is when the daemon is terminated,
    at which point it should simultaneously clear BMC_EVENT_DAEMON_READY and
    set BMC_EVENT_PROTOCOL_RESET. The DBus interface as designed required
    this be done as two separate messages, which lead to races propagating
    the complete state update to the host during shutdown of ipmid.
    Change-Id: Iaf38f77c28b8e4e4dd092b0de97dc7e777bfac65
    Signed-off-by: Andrew Jeffery's avatarAndrew Jeffery <andrew@aj.id.au>
mboxd.c 10.1 KB