GitLab

Hi,

I was just reading the buildroot defconfigs configs/blackbird-bmc_defconfig and configs/talos-bmc_defconfig and noticed that the option BR2_TARGET_GENERIC_HOSTNAME contains an underscore in both files:

• BR2_TARGET_GENERIC_HOSTNAME="blackbird_bangbmc"
• BR2_TARGET_GENERIC_HOSTNAME="talos_bangbmc"

As far as I'm aware, underscores are not allowed in hostnames, see e.g. https://en.wikipedia.org/wiki/Hostname#Restrictions_on_valid_hostnames or the man page hostname(7).

I'm still learning buildroot and I don't know exactly what the option BR2_TARGET_GENERIC_HOSTNAME does, but its name suggests it's used to specify the hostname on the target platform :)

If that's the case, what do you think about replacing the underscore with a hyphen, so that the hostnames become:

• blackbird-bangbmc
• talos-bangbmc

resolved in !1 (merged)

closed