Skip to content

GitLab

Switch branch/tag
  1. 26 Jun, 2011 4 commits
  3. 25 Jun, 2011 2 commits
  5. 19 Jun, 2011 4 commits
  7. 18 Jun, 2011 4 commits
  9. 17 Jun, 2011 2 commits
  11. 15 Jun, 2011 1 commit
  13. 14 Jun, 2011 1 commit
    • David Hendricks's avatar
      Use shutdown callback mechanism to shutdown programmers · 8bb2021d
      David Hendricks authored 
      
This patch attempts to resolve some programmer shutdown ordering issues
by having the programmer init functions register shutdown callbacks explicitly
wherever it makes most sense. Before, assumptions were made that could lead to
the internal programmer's state changing before the external programmer could be
shut down properly. Now, each programmer cleans up after itself and (hopefully)
performs each operation in the correct order.

As a side-effect, this patch gives us a better usage model for reverse
operations such as rpci_* and rmmio_*. In the long-run, this should make
reversing the initialization process easier to understand, less tedious, and
less error-prone.

In short, this patch does the following:
- Registers a shutdown callback during initialization for each programmer.
- Kills the .shutdown function pointer from programmer_entry struct. Also,
  make most shutdown functions static.
- Adds a few minor clean-ups and corrections (e.g. missing physunmap() calls).

TODO: Remove forward declaration of serprog_shutdown() (added to simplify diff)

Corresponding to flashrom svn r1338.
Signed-off-by: default avatarDavid Hendricks <dhendrix@google.com>
Acked-by: default avatarCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
      8bb2021d
  15. 13 Jun, 2011 2 commits
  17. 12 Jun, 2011 2 commits
  19. 11 Jun, 2011 6 commits
  21. 09 Jun, 2011 2 commits
  23. 06 Jun, 2011 1 commit
  25. 04 Jun, 2011 1 commit
  27. 03 Jun, 2011 1 commit
  29. 28 May, 2011 2 commits
  31. 26 May, 2011 3 commits
  33. 19 May, 2011 2 commits

Powered by Integricloud