Skip to content

GitLab

Switch branch/tag
  1. 25 Nov, 2009 4 commits
  3. 24 Nov, 2009 5 commits
  5. 23 Nov, 2009 2 commits
  7. 22 Nov, 2009 1 commit
    • Carl-Daniel Hailfinger's avatar
      ft2232_spi: add some error handling · a2441cef
      Carl-Daniel Hailfinger authored 
      
Pretty much everybody who used the FT2232 SPI driver had problems with
incorrect reads from time to time. One reason was that the hardware is
pretty timing sensitive even for reads.

The other reason was that the code silently ignored errors. This patch
doesn't add any error recovery, but it will emit error messages if
FT2232 communication goes wrong. That allows us to track down errors
without investing hours in driver debugging.

Thanks to Jeremy Buseman <naviathan@gmail.com> for testing. He found out
that certain libftdi/libusb/kernel/hardware combinations drop some bytes
without returning any error codes.

Corresponding to flashrom svn r769.
Signed-off-by: default avatarCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: default avatarPaul Fox <pgf@laptop.org>
      a2441cef
  9. 21 Nov, 2009 1 commit
  11. 20 Nov, 2009 1 commit
  13. 17 Nov, 2009 1 commit
  15. 16 Nov, 2009 4 commits
  17. 15 Nov, 2009 3 commits
  19. 14 Nov, 2009 2 commits
  21. 06 Nov, 2009 1 commit
  23. 31 Oct, 2009 1 commit
    • Carl-Daniel Hailfinger's avatar
      Add infrastructure to check the maximum supported flash size of chipsets and mainboards · 115d390f
      Carl-Daniel Hailfinger authored 
      
The rationale is to warn users when they, for example, try to flash
a 512KB parallel flash chip but their chipset only supports 256KB,
or they try to flash 512KB and the chipset _does_ theoretically
support 512KB but their special board doesn't wire all address lines
and thus supports only 256 KB ROM chips at maximum.

This has cost Uwe hours of debugging on some board already, until he
figured out what was going on. We should try warn our users where
possible about this.

The chipset and the chip may have more than one bus in common (e.g.
SB600 and Pm49* can both speak LPC+FWH) and on SB600/SB7x0/SB8x0 there
are different limits for LPC and FWH. The only way to tell the user
about the exact circumstances is to spew error messages per bus.

The code will issue a warning during probe (which does fail for some
chips if the size is too big) and abort before the first real
read/write/erase action. If no action is specified, the warning is
printed anyway.
That way, a user can find out why probe might not have worked, and will
be stopped before he/she gets incorrect results.

Add a bitcount function to the infrastructure.

Corresponding to flashrom svn r755.
Signed-off-by: default avatarCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: default avatarUwe Hermann <uwe@hermann-uwe.de>
      115d390f
  25. 30 Oct, 2009 1 commit
  27. 22 Oct, 2009 1 commit
    • Carl-Daniel Hailfinger's avatar
      ichspi: remove obnoxious debug message · 0709a782
      Carl-Daniel Hailfinger authored 
      
Since we don't have any debug level printing infrastructure yet, I
propose to kill the obnoxious debug message in ichspi.c which was added
to check for correct PREOP handling.

We know the code works fine (after getting a few reports over 100 MB
long) and there's no point in keeping it around anymore. If there is any
desire, we can reinstate it as print_spew or whatever once the debug
level infrastructure is merged, but at that point we probably just are
happy that the debug output isn't there anymore.

Corresponding to flashrom svn r753.
Signed-off-by: default avatarCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: default avatarLuc Verhaegen <libv@skynet.be>
      0709a782
  29. 21 Oct, 2009 1 commit
  31. 19 Oct, 2009 1 commit
  33. 06 Oct, 2009 4 commits
  35. 05 Oct, 2009 3 commits
  37. 03 Oct, 2009 1 commit
  39. 01 Oct, 2009 2 commits

Powered by Integricloud