Skip to content

GitLab

Switch branch/tag
  1. 16 May, 2009 2 commits
  3. 12 May, 2009 1 commit
  5. 11 May, 2009 1 commit
    • Carl-Daniel Hailfinger's avatar
      Check probing results for flash contents · 8130f2d3
      Carl-Daniel Hailfinger authored 
      
When flashrom JEDEC code sends the ID command to the chip, it expects to
see IDs in the default flash location.

However, sometimes the chip does not react to the ID command, either
because it doesn't understand the command or because the command never
reached it. One way to detect this is to compare ID output with flash
chip contents for the same location. If they are identical, there is a
high chance you're not actually seeing ID output. Warn the user in that
case.

This patch helps a lot when a chip is not recognized and we want to
check if the probe responses are real IDs or just random flash chip
contents.

This should probably be added to all probe functions, but probe_jedec
is called for all sizes and thus flashrom will check this condition at
least once per size, making sure we can cross-match the warning.

Corresponding to flashrom svn r494.
Signed-off-by: default avatarCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: FENG Yu Ning <fengyuning1984@gm...
      8130f2d3
  7. 06 Mar, 2009 1 commit
  9. 05 Mar, 2009 1 commit
    • Carl-Daniel Hailfinger's avatar
      Use helper functions to access flash chips · 61a8bd27
      Carl-Daniel Hailfinger authored 
      
Right now we perform direct pointer manipulation without any abstraction
to read from and write to memory mapped flash chips. That makes it
impossible to drive any flasher which does not mmap the whole chip.

Using helper functions readb() and writeb() allows a driver for external
flash programmers like Paraflasher to replace readb and writeb with
calls to its own chip access routines.

This patch has the additional advantage of removing lots of unnecessary
casts to volatile uint8_t * and now-superfluous parentheses which caused
poor readability.

I used the semantic patcher Coccinelle to create this patch. The
semantic patch follows:
@@
expression a;
typedef uint8_t;
volatile uint8_t *b;
@@
- *(b) = (a);
+ writeb(a, b);
@@
volatile uint8_t *b;
@@
- *(b)
+ readb(b)
@@
type T;
T b;
@@
(
 readb
|
 writeb
)
 (...,
- (T)
- (b)
+ b
 )

In contrast to a sed script, the semantic patch performs type checking
before converting anything.

Tested-by: Joe Julian

Corresponding to flashrom svn r418 and coreboot v2 svn r3971.
Signed-off-by: default avatarCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: default avatarFENG Yu Ning <fengyuning1984@gmail.com>
      61a8bd27
  11. 25 Jan, 2009 1 commit
  13. 24 Jun, 2008 1 commit
  15. 21 Jun, 2008 2 commits
  17. 14 May, 2008 1 commit
  19. 31 Dec, 2007 1 commit
    • Carl-Daniel Hailfinger's avatar
      Add continuation ID support to jedec.c · ae8afa9d
      Carl-Daniel Hailfinger authored 
      
The continuation ID code does not go further than checking for IDs of
the type 0x7fXX, but does this for vendor and product ID. The current
published JEDEC spec has a list where the largest vendor ID is 7 bytes
long, but all leading bytes are 0x7f. The list will grow in the future,
and using a 64bit variable will not be enough anymore.
Besides that, it seems that the location of the ID byte after the first
continuation ID byte is very vendor specific, so we may have to revisit
that code some time in the future.

(Suggestion for a new encoding:
Use a two-byte data type for the ID, the lower byte contains the only
non-0x7f byte, the upper byte contains the number of 0x7f bytes used as
prefix, which is the bank number minus 1 the vendor ID appears in.)

Add support for EON EN29F002AT.

Corresponding to flashrom svn r171 and coreboot v2 svn r3030.
Signed-off-by: default avatarCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: default avatarCorey Osgood <corey.osgood@gmail.com>
      ae8afa9d
  21. 13 Nov, 2007 1 commit
  23. 17 Oct, 2007 1 commit
  25. 12 Oct, 2007 1 commit
  27. 09 Sep, 2007 1 commit
  29. 29 Aug, 2007 1 commit
  31. 23 Aug, 2007 3 commits
  33. 23 May, 2007 1 commit
  35. 09 May, 2007 1 commit
  37. 22 Nov, 2006 1 commit
  39. 23 Aug, 2006 1 commit
  41. 26 Nov, 2005 1 commit
  43. 08 Dec, 2004 2 commits
  45. 07 Dec, 2004 1 commit
  47. 30 Sep, 2004 1 commit
  49. 27 Mar, 2004 2 commits
  51. 22 Mar, 2004 1 commit
  53. 20 Mar, 2004 2 commits
  55. 19 Mar, 2004 1 commit
  57. 12 Sep, 2003 1 commit
  59. 28 Feb, 2003 1 commit
  61. 06 Sep, 2002 1 commit
  63. 29 Jan, 2002 2 commits

Powered by Integricloud