Commit db53ec53 authored by Carl-Daniel Hailfinger's avatar Carl-Daniel Hailfinger
Browse files

Add a few FIXME comments to the generic SPI code


Corresponding to flashrom svn r814.
Signed-off-by: default avatarCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: default avatarCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
parent 14e100c9
......@@ -807,6 +807,7 @@ int spi_write_status_register(int status)
int result;
struct spi_command cmds[] = {
{
/* FIXME: WRSR requires either EWSR or WREN depending on chip type. */
.writecnt = JEDEC_EWSR_OUTSIZE,
.writearr = (const unsigned char[]){ JEDEC_EWSR },
.readcnt = 0,
......@@ -1059,6 +1060,7 @@ int spi_aai_write(struct flashchip *flash, uint8_t *buf)
fprintf(stderr, "ERASE FAILED!\n");
return -1;
}
/* FIXME: This will fail on ICH/VIA SPI. */
result = spi_write_enable();
if (result)
return result;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment