Commit bc25f947 authored by Carl-Daniel Hailfinger's avatar Carl-Daniel Hailfinger Committed by Stefan Reinauer
Browse files

Boards with coreboot have a cbtable containing vendor and board name


Flashrom tries to match these with board enable entries in its database.
If no such board enable entry exists because the board doesn't need one,
flashrom complains. Silence that complaint.

Corresponding to flashrom svn r668.
Signed-off-by: default avatarCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Slightly updated and
Acked-by: default avatarStefan Reinauer <stepan@coresystems.de>
parent 350a0c34
......@@ -1134,7 +1134,14 @@ static struct board_pciid_enable *board_match_coreboot_name(const char *vendor,
if (partmatch)
return partmatch;
printf("\nUnknown vendor:board from coreboot table or -m option: %s:%s\n\n", vendor, part);
if (!partvendor_from_cbtable) {
/* Only warn if the mainboard type was not gathered from the
* coreboot table. If it was, the coreboot implementor is
* expected to fix flashrom, too.
*/
printf("\nUnknown vendor:board from -m option: %s:%s\n\n",
vendor, part);
}
return NULL;
}
......@@ -1187,7 +1194,7 @@ int board_flash_enable(const char *vendor, const char *part)
board = board_match_pci_card_ids();
if (board) {
printf("Found board \"%s %s\", enabling flash write... ",
printf("Disabling flash write protection for board \"%s %s\"... ",
board->vendor_name, board->board_name);
ret = board->enable(board->vendor_name);
......
......@@ -31,6 +31,7 @@
#include "coreboot_tables.h"
char *lb_part = NULL, *lb_vendor = NULL;
int partvendor_from_cbtable = 0;
static unsigned long compute_checksum(void *addr, unsigned long length)
{
......@@ -150,6 +151,7 @@ static void find_mainboard(struct lb_record *ptr, unsigned long addr)
if (lb_part) {
printf("Overwritten by command line, vendor ID: %s, part ID: %s.\n", lb_vendor, lb_part);
} else {
partvendor_from_cbtable = 1;
lb_part = strdup(part);
lb_vendor = strdup(vendor);
}
......
......@@ -402,6 +402,7 @@ int handle_romentries(uint8_t *buffer, uint8_t *content);
/* cbtable.c */
int coreboot_init(void);
extern char *lb_part, *lb_vendor;
extern int partvendor_from_cbtable;
/* spi.c */
enum spi_controller {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment