Commit a3712817 authored by Stefan Tauner's avatar Stefan Tauner
Browse files

Fix file descriptor leak in serial.c


Found by Coverity as "CID 1348465:  Resource leaks".

Corresponding to flashrom svn r1915.
Signed-off-by: default avatarStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
Acked-by: default avatarStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
parent 1ca7c7ff
......@@ -282,18 +282,20 @@ fdtype sp_openserport(char *dev, int baud)
const int flags = fcntl(fd, F_GETFL);
if (flags == -1) {
msg_perr_strerror("Could not get serial port mode: ");
return SER_INV_FD;
goto err;
}
if (fcntl(fd, F_SETFL, flags & ~O_NONBLOCK) != 0) {
msg_perr_strerror("Could not set serial port mode to blocking: ");
return SER_INV_FD;
goto err;
}
if (serialport_config(fd, baud) != 0) {
close(fd);
return SER_INV_FD;
goto err;
}
return fd;
err:
close(fd);
return SER_INV_FD;
#endif
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment