Commit 8c1df280 authored by Michael Karcher's avatar Michael Karcher
Browse files

Warn if running on laptops


Corresponding to flashrom svn r916.
Signed-off-by: default avatarMichael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>
Acked-by: default avatarCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
parent 0d7fb7c5
......@@ -98,6 +98,7 @@ static char *get_dmi_string(const char *string_name)
void dmi_init(void)
{
int i;
char *chassis_type;
has_dmi_support = 1;
for (i = 0; i < DMI_ID_INVALID; i++) {
dmistrings[i] = get_dmi_string(dmidecode_names[i]);
......@@ -106,6 +107,13 @@ void dmi_init(void)
break;
}
}
chassis_type = get_dmi_string("chassis-type");
if (chassis_type && !strcmp(chassis_type, "Notebook")) {
printf_debug("Laptop detected via DMI");
is_laptop = 1;
}
free(chassis_type);
}
/**
......
......@@ -382,6 +382,7 @@ struct pci_dev *pci_card_find(uint16_t vendor, uint16_t device,
void get_io_perms(void);
void release_io_perms(void);
#if INTERNAL_SUPPORT == 1
extern int is_laptop;
void probe_superio(void);
int internal_init(void);
int internal_shutdown(void);
......
......@@ -110,6 +110,8 @@ void probe_superio(void)
#endif
}
int is_laptop;
int internal_init(void)
{
int ret = 0;
......@@ -131,6 +133,16 @@ int internal_init(void)
/* Probe for the SuperI/O chip and fill global struct superio. */
probe_superio();
/* Warn if a laptop is detected */
if (is_laptop)
printf("========================================================================\n"
"WARNING! You seem to be running flashrom on a laptop.\n"
"Laptops, notebooks and netbooks are difficult to support and we recommend\n"
"to use the vendor flashing utility. The embedded controller (EC) in these\n"
"machines often interacts badly with flashing\n"
"See http://www.flashrom.org/Laptops\n"
"========================================================================\n");
/* try to enable it. Failure IS an option, since not all motherboards
* really need this to be done, etc., etc.
*/
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment