Commit 30f7cb2f authored by Carl-Daniel Hailfinger's avatar Carl-Daniel Hailfinger
Browse files

Flashrom only checks for very few chips if the erase worked


And even when it checks if the erase worked, the result of that check is
often ignored.

Convert all erase functions and actually check return codes
almost everywhere.
Check inside all erase_* routines if erase worked, not outside.
erase_sector_jedec and erase_block_jedec have changed prototypes to
enable erase checking.

Uwe successfully tested LPC on an CK804 box and SPI on some SB600 box.

Corresponding to flashrom svn r595.
Signed-off-by: default avatarCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Signed-off-by: default avatarUrja Rannikko <urjaman@gmail.com>
Acked-by: default avatarUwe Hermann <uwe@hermann-uwe.de>
parent 08454644
......@@ -27,7 +27,10 @@ int write_49f002(struct flashchip *flash, uint8_t *buf)
int page_size = flash->page_size;
chipaddr bios = flash->virtual_memory;
erase_chip_jedec(flash);
if (erase_chip_jedec(flash)) {
fprintf(stderr, "ERASE FAILED!\n");
return -1;
}
printf("Programming page: ");
for (i = 0; i < total_size / page_size; i++) {
......
......@@ -196,7 +196,10 @@ int wbsio_spi_write_1(struct flashchip *flash, uint8_t *buf)
return 1;
}
flash->erase(flash);
if (flash->erase(flash)) {
fprintf(stderr, "ERASE FAILED!\n");
return -1;
}
result = spi_write_enable();
if (result)
return result;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment