Commit 051e2366 authored by Stefan Reinauer's avatar Stefan Reinauer Committed by Stefan Reinauer
Browse files

Avoid printing mapped addresses for programmers that do not map flash chips


Don't print the local memory flash chip address on programmers that
don't actually map the flash chip into local memory (like the dediprog)
because the value does not make sense there.

This version was reworked / rewritten by Mathias Krause to have less
"impact"

Corresponding to flashrom svn r1253.
Signed-off-by: default avatarStefan Reinauer <reinauer@google.com>
Acked-by: default avatarMathias Krause <mathias.krause@secunet.com>
parent a60faab8
......@@ -1127,6 +1127,7 @@ struct flashchip *probe_flash(struct flashchip *first_flash, int force)
{
struct flashchip *flash;
unsigned long base = 0;
char location[64];
uint32_t size;
enum chipbustype buses_common;
char *tmp;
......@@ -1178,10 +1179,16 @@ notfound:
if (!flash || !flash->name)
return NULL;
msg_cinfo("%s chip \"%s %s\" (%d KB, %s) at physical address 0x%lx.\n",
if (programmer_table[programmer].map_flash_region == physmap) {
snprintf(location, sizeof(location), "at physical address 0x%lx", base);
} else {
snprintf(location, sizeof(location), "on %s", programmer_table[programmer].name);
}
msg_cinfo("%s chip \"%s %s\" (%d KB, %s) %s.\n",
force ? "Assuming" : "Found",
flash->vendor, flash->name, flash->total_size,
flashbuses_to_text(flash->bustype), base);
flashbuses_to_text(flash->bustype), location);
/* Flash registers will not be mapped if the chip was forced. Lock info
* may be stored in registers, so avoid lock info printing.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment