"...0d0cea2424ae97b27447dc64a7dbfae83c036c45b403392f0e8ba.png" did not exist on "dev-5.0-raptor-04-16-2019"
  • Carl-Daniel Hailfinger's avatar
    Use REMS instead of RES in the ICH SPI default opcode table · 15aa7c65
    Carl-Daniel Hailfinger authored
    
    RES is Read Electronic Signature (1 Byte, identical for different chips)
    REMS is Read Electronic Manufacturer Signature (2 Bytes, mostly unique)
    RDID is Read JEDEC ID (3 bytes, unique)
    
    Of the chips which don't support RDID, a sizable portion supports REMS
    which gives us both a manufacturer ID and a device ID. This is clearly
    superior to having only a device ID (the RES case) which has multiple
    documented collisions.
    
    The RES/REMS problem is aggravated by inconsistent naming in vendor data
    sheets. What's in a name? Considering that we have 1-byte IDs, 2-byte
    IDs and 3+byte IDs with varying names but mostly consistent opcodes, it
    makes sense to set our own standard about how the opcodes are called.
    
    The best way forward would be to have the ICH SPI driver reprogram the
    opcode menu on the fly if the opcode menu doesn't contain the requested
    opcode and the opcode menu is not locked. Until that happens, this patch
    improves detection accuracy by a factor of 256 for some chips.
    
    Corresponding to flashrom svn r549.
    Signed-off-by: default avatarCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
    
    Tested-by: Uwe Hermann
    with the flash chip "SST SST25VF040.REMS".
    Acked-by: default avatarRonald G. Minnich <rminnich@gmail.com>
    15aa7c65
ichspi.c 19.1 KB