• Stefan Tauner's avatar
    Fix garbage handling in DMI strings · 9972d15e
    Stefan Tauner authored
    
    Previously we tried to replace garbage characters with <space> directly in
    the read-only memory-mapped SMBIOS area(!). This could never have
    worked for any DMI strings with garbage and results in a segfault on
    machines with such strings.
    
    Thanks to Brian Rak (Supermicro X10SLE-F) and John Pohlman (HP XW9400)
    for reporting this issue.
    
    With this patch the strings are duplicated within dmi_string() already,
    just before we sanitize them. Also, the limit variable used everywhere
    points to the first invalid byte address. Refine respective checks
    accordingly.
    
    Corresponding to flashrom svn r1824.
    Signed-off-by: default avatarStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
    Acked-by: default avatarCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
    9972d15e
dmi.c 12.6 KB