Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
B
bootrom
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • Kestrel Collaboration
  • Kestrel Firmware
  • bootrom
  • Merge Requests
  • !16

Closed
Opened Mar 11, 2021 by Jonathan Currier@dormito
  • Report abuse
Report abuse

Address space remapping means rom will no longer be at 0x0

  • Overview 2
  • Commits 1
  • Changes 1

Because the remapping means rom no longer starts at 0x0, this assert will break.

I thought about checking that _start == 0x40000000 but ultimately that did not seem like a good idea to me either. If you have any alternatives to suggest besides dropping the assert I'd be interested.

See also:

https://gitlab.raptorengineering.com/kestrel-collaboration/kestrel-litex/litex-boards/-/merge_requests/5 (and related)

Edited Mar 11, 2021 by Jonathan Currier

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch "http://gitlab.raptorengineering.com/dormito/bootrom.git" "dormito/address-space-remap"
git checkout -b "dormito/bootrom-dormito/address-space-remap" FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "dormito/bootrom-dormito/address-space-remap"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: kestrel-collaboration/kestrel-firmware/bootrom!16

Powered by Integricloud