From 6b8622a1a4d4839516868580fd65dc1212e21f00 Mon Sep 17 00:00:00 2001 From: Jonathan Currier Date: Mon, 26 Aug 2019 18:05:30 -0500 Subject: [PATCH] Harden against null pointer derefs --- protocol.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/protocol.c b/protocol.c index 92c0ec5..955e837 100644 --- a/protocol.c +++ b/protocol.c @@ -61,7 +61,9 @@ int protocol_events_set(struct mbox_context *context, uint8_t bmc_event) */ context->bmc_events |= bmc_event; - return context->transport->ops->set_events(context->transport, bmc_event, mask); + return (context->transport) ? + context->transport->set_events(context, bmc_event, mask) : + (mbox_log(LOG_ERR, "Called %s, but transport not assigned", __func__), -1); } /* @@ -78,7 +80,9 @@ int protocol_events_clear(struct mbox_context *context, uint8_t bmc_event) context->bmc_events &= ~bmc_event; - return context->transport->ops->clear_events(context->transport, bmc_event, mask); + return (context->transport) ? + context->transport->ops->clear_events(context->transport, bmc_event, mask) : + (mbox_log(LOG_ERR, "Called %s, but transport not assigned", __func__), -1); } static int protocol_negotiate_version(struct mbox_context *context, -- 2.30.2